Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require firebase JWT lib #7372

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Require firebase JWT lib #7372

merged 1 commit into from
Jun 14, 2022

Conversation

nickvergessen
Copy link
Member

For #7336

@nickvergessen nickvergessen added 3. to review enhancement feature: signaling 📶 Internal and external signaling backends labels May 16, 2022
@nickvergessen nickvergessen added this to the 💚 Next Major (25) milestone May 16, 2022
@nickvergessen nickvergessen requested a review from fancycode May 16, 2022 09:46
fancycode
fancycode requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

You might want to add a call to composer install --no-dev somewhere in the
Makefile so the library is fetched while building the app. Also it should be included in the resulting app tarball (currently vendor is excluded).

@fancycode fancycode mentioned this pull request Jun 10, 2022
Merged
2 tasks
@nickvergessen
Require firebase JWT lib
f0edd9c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/7336/JWT-for-HPB-authentication branch from 95d745b to f0edd9c Compare June 10, 2022 10:12
@nickvergessen
Copy link
Member Author

Adjusted

@nickvergessen nickvergessen requested a review from fancycode June 10, 2022 10:12
@nickvergessen
Copy link
Member Author

Also checked and the release building action also does composer install --no-dev :
https://github.com/nextcloud/spreed/blob/master/.github/workflows/appstore-build-publish.yml#L80-L84

fancycode
fancycode approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@nickvergessen nickvergessen merged commit 3ea410d into master Jun 14, 2022
@nickvergessen nickvergessen deleted the feature/7336/JWT-for-HPB-authentication branch June 14, 2022 14:29
@fancycode fancycode mentioned this pull request Jun 17, 2022
Closed
@danxuliu danxuliu mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancycode fancycode fancycode approved these changes

Assignees
No one assigned
Labels
4. to release enhancement feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Milestone
v15.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @fancycode